Code review comment for lp:~wallyworld/launchpad/recipe-build-removed-recipe
Revision history for this message
| Ian Booth (wallyworld) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4d1350f
(Get the code!)
I've added a test as requested in
lp.code.
On 02/02/11 01:51, Leonard Richardson wrote:
> Review: Approve
> This looks fine.
>
> As you say, the code should work even if it's run in multiple transactions and the recipe is deleted during processing. But, maybe you want to test this--add a test that nothing happens when you call notify() on a build whose recipe has been deleted. It shouldn't be difficult.