Code review comment for lp:~wallyworld/launchpad/recipe-build-removed-recipe

Revision history for this message
Leonard Richardson (leonardr) wrote :

This looks fine.

As you say, the code should work even if it's run in multiple transactions and the recipe is deleted during processing. But, maybe you want to test this--add a test that nothing happens when you call notify() on a build whose recipe has been deleted. It shouldn't be difficult.

review: Approve

« Back to merge proposal