Code review comment for lp:~wallyworld/launchpad/recipe-build-now

Revision history for this message
Ian Booth (wallyworld) wrote :

Hi again

> RE: placement of Build Now button/link

I'll talk to Tim about the (valid) issues you raise and see what his
preferred option is etc.

>
> Also, I just noticed something else. Changing "Built daily" to "Built on request" (ajax popup) and back does not hide or show the new link. It takes a page reload to hide/show it. For the story to be complete, this should work in ajax, too.
>

Yes, this is a current known limitation and we are waiting on work by
Leonard on the javascript/webservices side before this issue can be
addressed. Good job on noticing it :-)

« Back to merge proposal