Code review comment for lp:~wallyworld/launchpad/pillar-access-service-infrastructure

Revision history for this message
Ian Booth (wallyworld) wrote :

Hi Rob

> Two nits:
> - don't accept broken stuff in our stack: that as_of beta should be
> fixed at root.

Ok. I wasn't 100% sure it was broken or me not appreciating a subtlety
of the lazr restful versioning. I'll file a bug and put in a XXX if we
think it is indeed broken.

> - /services/ will collide with a product called services won't it?
> Please use /+services instead to mitigate this.
>

I had planned on adding services to the names blacklist. My opinion is
that "services" should be a reserved word in this sense but if you fell
strongly that it should be +services I'll do that.

« Back to merge proposal