Merge lp:~wallyworld/launchpad/openid-oops-810623 into lp:launchpad
Proposed by
Ian Booth
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16173 |
Proposed branch: | lp:~wallyworld/launchpad/openid-oops-810623 |
Merge into: | lp:launchpad |
Diff against target: |
86 lines (+33/-6) 2 files modified
lib/lp/services/webapp/login.py (+20/-6) lib/lp/services/webapp/tests/test_login.py (+13/-0) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/openid-oops-810623 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+130467@code.launchpad.net |
Commit message
Display a login error rather than oopsing if open id provider sends a response with missing fields
Description of the change
== Implementation ==
When the response from the open id provider does not contain the expected full name and email fields, display the error page rather than oopsing.
== Tests ==
Add new test to TestOpenIDCallb
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
To post a comment you must log in.
Thank. I really do dislike the "assert" keyword