Code review comment for lp:~wallyworld/launchpad/no-private-bug-rss

Revision history for this message
Ian Booth (wallyworld) wrote :

>
> What exactly is auth_browser for? If you merely need a brower for a logged-in user, there's no need to construct one; use user_browser which is set up implicitly for this usage.
>

I looked at the code again in more detail. I need more than just "a"
logged in user. I need a browser logged in for a specific user so that a
private bug and a private branch can be accessed. Hence I get the user I
need:

user = getUtility(IPersonSet).getByEmail('<email address hidden>')

and then get the logged in browser for that user, using the password =
'daf':

auth_browser = setupBrowserForUser(user, 'daf')

So I think the use of auth_browser is ok unless there is something I am
missing.

« Back to merge proposal