> Since I don't see you on IRC and I might be leaving soon, here's what I typed
> there:
> * I don't think the way you introduced security adapter is sufficient: in my
> reading, it modifies the launchpad.Admin privilege for BugTask to match the
> launchpad.Delete privilege, but does not really allow admins to do the delete
> * your test is not really testing what I thought it should (i.e. log in as
> <email address hidden> and not someone holding a contextual launchpad.Admin
> permission [like target owner])
> * (or better yet, login_celebrity('admin') from the same module login is in)
>
You are right - my test was flawed and the security adaptor wasn't quite right. They're both fixed now.
> Since I don't see you on IRC and I might be leaving soon, here's what I typed ('admin' ) from the same module login is in)
> there:
> * I don't think the way you introduced security adapter is sufficient: in my
> reading, it modifies the launchpad.Admin privilege for BugTask to match the
> launchpad.Delete privilege, but does not really allow admins to do the delete
> * your test is not really testing what I thought it should (i.e. log in as
> <email address hidden> and not someone holding a contextual launchpad.Admin
> permission [like target owner])
> * (or better yet, login_celebrity
>
You are right - my test was flawed and the security adaptor wasn't quite right. They're both fixed now.