Code review comment for lp:~wallyworld/launchpad/delete-bugtasks-1324

Revision history for this message
Ian Booth (wallyworld) wrote :

>
> > Next, I wonder if there was a good reason not to use launchpad.Admin
> privilege
> > instead? I.e. the way you implement Delete for BugTask seems limited to
> > checking permissions on the context. Real admins (like LOSAs) will not be
> able
> > to delete bug tasks, if I am reading it correctly.
> >
>
> I think this is a good point to raise and we need to add support for
> launchpad.Admin to be able to delete bug tasks.
>

I've added a security adapter to allow lp admins to also delete bug tasks.

« Back to merge proposal