Code review comment for lp:~wallyworld/launchpad/delete-bugtask-ui-878909

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you for fixing this Ian. I wish I remembered to my troubled writing tests for bug nominations where I too discovered the misdirection with the LaunchpadBag. While LaunchpadView, and most proper Zope views requires a context (bugtask) and a request passed on __init__, the very old bug and bugtask views did not use that. We might be able to remove the LaunchpadBag hacks if all the views are LaunchpadViews.

This looks good to land.

review: Approve (code)

« Back to merge proposal