Code review comment for lp:~wallyworld/launchpad/codehost-error-trackback-leak

On Tue, Dec 7, 2010 at 3:26 AM, Ian Booth <email address hidden> wrote:
>> Someone told me we had a monkeypatch helper method that added the cleanup
>> code.  If that isn't the case, you could still to the cleanup with addCleanup
>> rather than adding a tearDown method.
>>
>
> The implementation used mirrors what is done already in the current
> tests for this part of the code. If I am to change the implementation as
> per the review recommendations, the other existing tests should also be
> changed to maintain consistency. I thought it best to use code similar
> to what was already there rather than change unrelated code and increase
> the diff size etc. I'll look into making the required changes though.

The other tests are merely aggregated - there's no interaction between
two different test classes that makes consistency valuable here.

IMNSHOly-yrs,
Rob