Code review comment for lp:~wallyworld/launchpad/better-popup-show-widget-name

On 26/05/11 00:08, Curtis Hovey wrote:
> There were no cases in the past were we could have collisions are described. Most of the fields we use in control names are based on lp name fields. Is there an example of a field where this can happen?
>

I made the above argument on irc but was assured there is a remote
chance a collision could happen. This page:

https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/713922

has a dom node which is named after the project gtk+2.0 and the argument
made to me was that since such cases involve not just lp name fields
with statically unique names but names derived from user data, there is
a remote chance there may be a collision at some point in the future and
we shouldn't put in code which is ok now but may break later. I still
don't see how it could happen but deferred to those with more lp knowledge.

> If this really can happen, then I propose that the method take an optional arg (tales does not need this) that appends the base64 encoding so that we have a human-readable fragment that can be debugged.
>
> Most importantly, I do not think we want two implementations. A smarter function may be all that we need.

Agree with the above. My suggestion was that the existing formatter be
enhanced if deemed necessary.