Code review comment for lp:~wallyworld/launchpad/assign-non-contributor

Revision history for this message
Ian Booth (wallyworld) wrote :

>
>> In any case, I've made the suggested changes. It does mean less lines of
>> code. The coding guidelines say not to concatenate strings over more
>> than 3 lines so I've used the approach of ['foo', 'bar'].join('') as per
>> the guidelines.
>
> It was a single string literal, not a series of concatenations, but OK. Neither is pretty.
>

Ah, it was changed to a single literal from a series of concatenations,
my mistake in the wording above sorry. But I also thought that using "\"
for line continuation was forbidden too :-)

> One remaining stylistic niggle: extra_form_buttons and important-notice-popup have styles added, but one uses hyphens and the other underscores. I guess we probably have a standard for this.

Yes, you are right. I missed that inconsistency. I will change it, thanks.

« Back to merge proposal