Code review comment for lp:~wallyworld/juju-core/verbose-metadata-validation

Reviewers: mp+209162_code.launchpad.net,

Message:
Please take a look.

Description:
Add metadata to simplestreams validation

juju metadata validate-[images|tools] now prints
metadata to show how the lookup was performed.
Along the way, drive by fixes were done to delete
old code and improve existing code associated with
simplestreams.

A picture is worth 1000 words:

ian@wallyworld:~$ juju metadata validate-images
ImageIds:
- ami-99999af0
- ami-0d9c9f64
- ami-6f969506

- ami-0b9c9f62

- ami-359c9f5c

- ami-a18c8fc8

Region: us-east-1

Resolve Metadata:

   source: default cloud images

   signed: true

   indexURL:
http://cloud-images.ubuntu.com/releases/streams/v1/index.sjson

ian@wallyworld:~$ juju metadata validate-tools
Matching Tools Versions:
- 1.17.4-precise-amd64
- 1.17.4-precise-i386
Resolve Metadata:
   source: default simplestreams
   signed: false
   indexURL:
https://streams.canonical.com/juju/tools/streams/v1/index.json
   mirrorURL: https://juju-dist.s3.amazonaws.com/tools

https://code.launchpad.net/~wallyworld/juju-core/verbose-metadata-validation/+merge/209162

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/70960044/

Affected files (+330, -361 lines):
   A [revision details]
   M cmd/plugins/juju-metadata/toolsmetadata.go
   M cmd/plugins/juju-metadata/validateimagemetadata.go
   M cmd/plugins/juju-metadata/validateimagemetadata_test.go
   M cmd/plugins/juju-metadata/validatetoolsmetadata.go
   M cmd/plugins/juju-metadata/validatetoolsmetadata_test.go
   M environs/bootstrap/bootstrap_test.go
   M environs/imagemetadata/generate.go
   M environs/imagemetadata/generate_test.go
   M environs/imagemetadata/simplestreams.go
   M environs/imagemetadata/simplestreams_test.go
   M environs/imagemetadata/testing/testing.go
   M environs/imagemetadata/urls.go
   M environs/imagemetadata/validation.go
   M environs/imagemetadata/validation_test.go
   M environs/instances/image_test.go
   M environs/simplestreams/datasource.go
   M environs/simplestreams/datasource_test.go
   M environs/simplestreams/simplestreams.go
   M environs/simplestreams/simplestreams_test.go
   M environs/storage/storage.go
   M environs/storage/storage_test.go
   M environs/sync/sync.go
   D environs/tools/boilerplate.go
   M environs/tools/simplestreams.go
   M environs/tools/simplestreams_test.go
   M environs/tools/testing/testing.go
   M environs/tools/tools.go
   M environs/tools/urls.go
   M environs/tools/validation.go
   M environs/tools/validation_test.go
   M provider/azure/environ.go
   M provider/azure/instancetype.go
   M provider/azure/instancetype_test.go
   M provider/common/mock_test.go
   M provider/dummy/environs.go
   M provider/ec2/ec2.go
   M provider/ec2/image.go
   M provider/ec2/image_test.go
   M provider/ec2/local_test.go
   M provider/local/environ.go
   M provider/maas/environ.go
   M provider/manual/environ.go
   M provider/openstack/image.go
   M provider/openstack/local_test.go
   M provider/openstack/provider.go