Code review comment for lp:~wallyworld/juju-core/upgrade-remove-old-config

Revision history for this message
Ian Booth (wallyworld) wrote :

https://codereview.appspot.com/70230049/diff/1/upgrades/deprecatedattributes_test.go
File upgrades/deprecatedattributes_test.go (right):

https://codereview.appspot.com/70230049/diff/1/upgrades/deprecatedattributes_test.go#newcode46
upgrades/deprecatedattributes_test.go:46:
c.Assert(allAttrs["public-bucket"], gc.Equals, "foo")
On 2014/03/04 03:04:57, thumper wrote:
> Seems a lot to me to have the asserts in setup for this

I can remove them but these serve to double check that the attributes
really are set so that we can be sure the test is testing what we think
it is.

https://codereview.appspot.com/70230049/

« Back to merge proposal