Code review comment for lp:~wallyworld/juju-core/upgrade-remove-old-config

Reviewers: mp+208986_code.launchpad.net,

Message:
Please take a look.

Description:
Deprecated attributes upgrader

Previous versions of Juju will have left deprecated
attributes hanging around in the environment. This
upgrader will remove such attributes from env state.
eg default-image-id which is ignored will be put
into env state. This upgrader removes it. Also,
the deprecated attributes are no longer propagated
when a new env config is made.

https://code.launchpad.net/~wallyworld/juju-core/upgrade-remove-old-config/+merge/208986

Requires:
https://code.launchpad.net/~axwalk/juju-core/upgrade-syslog-port/+merge/208724

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/70230049/

Affected files (+165, -16 lines):
   A [revision details]
   M cmd/jujud/machine.go
   M cmd/jujud/unit.go
   M cmd/jujud/upgrade_test.go
   M cmd/logging.go
   M cmd/logging_test.go
   M provider/openstack/config.go
   M provider/openstack/config_test.go
   A upgrades/deprecatedattributes.go
   A upgrades/deprecatedattributes_test.go
   M upgrades/export_test.go
   M upgrades/steps118.go
   M upgrades/steps118_test.go
   M upgrades/systemsshkey_test.go