Code review comment for lp:~wallyworld/juju-core/provisioner-retry

Revision history for this message
William Reade (fwereade) wrote :

I would be so much happier if this was implemented as a StringsWatcher,
that sent down the ids-to-be-retried list, and we were able to call
exactly the same processMachines method -- and thus be able to convert
everything in one go to use the bulk apis that already exist.

https://codereview.appspot.com/80340043/diff/60001/state/machine_test.go
File state/machine_test.go (right):

https://codereview.appspot.com/80340043/diff/60001/state/machine_test.go#newcode1058
state/machine_test.go:1058: c.Assert(err, gc.ErrorMatches, `cannot set
status "pending"`)
We should also be able to set "pending" when it's currently in "error"
state, right?

https://codereview.appspot.com/80340043/

« Back to merge proposal