On 2013/11/14 10:38:00, jameinel wrote: > LGTM
https://codereview.appspot.com/25480047/diff/20001/state/apiserver/provisioner/provisioner_test.go > File state/apiserver/provisioner/provisioner_test.go (right):
https://codereview.appspot.com/25480047/diff/20001/state/apiserver/provisioner/provisioner_test.go#newcode801 > state/apiserver/provisioner/provisioner_test.go:801: }) > The only other test I've seen here is a machine that doesn't exist still shows > up as ErrUnauthorized rather than ErrNotFound. > I think you can do that with just adding
> { > MachineTag: "machine-42", > ... > },
Done
https://codereview.appspot.com/25480047/
« Back to merge proposal
On 2013/11/14 10:38:00, jameinel wrote:
> LGTM
https:/ /codereview. appspot. com/25480047/ diff/20001/ state/apiserver /provisioner/ provisioner_ test.go /provisioner/ provisioner_ test.go (right):
> File state/apiserver
https:/ /codereview. appspot. com/25480047/ diff/20001/ state/apiserver /provisioner/ provisioner_ test.go# newcode801 /provisioner/ provisioner_ test.go: 801: })
> state/apiserver
> The only other test I've seen here is a machine that doesn't exist
still shows
> up as ErrUnauthorized rather than ErrNotFound.
> I think you can do that with just adding
> {
> MachineTag: "machine-42",
> ...
> },
Done
https:/ /codereview. appspot. com/25480047/