Code review comment for lp:~wallyworld/juju-core/log-deprecated-config-warnings

Revision history for this message
Ian Booth (wallyworld) wrote :

Reviewers: mp+199597_code.launchpad.net,

Message:
Please take a look.

Description:
Fix config depcared attr warnings

Deprecated config warnings are being logged
multiple times. A previous fix moved the entire
deprecated config processing logic so that the
warnings were only logged once. However this broke
upgrades.

This new fix moves the logging of the deprecation
warnings but leaves the processing of the depcated
attributes in the config Validate method so
upgrades continue to work.

https://code.launchpad.net/~wallyworld/juju-core/log-deprecated-config-warnings/+merge/199597

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/37720049/

Affected files (+110, -123 lines):
   A [revision details]
   M environs/config.go
   M environs/config/config.go
   M environs/config/config_test.go
   M environs/config_test.go
   M environs/export_test.go

« Back to merge proposal