https://codereview.appspot.com/86360043/diff/1/juju/arch/arch.go File juju/arch/arch.go (left):
https://codereview.appspot.com/86360043/diff/1/juju/arch/arch.go#oldcode39 juju/arch/arch.go:39: {regexp.MustCompile("aarch64"), ARM64}, On 2014/04/10 10:49:31, thumper wrote: > does this line need to be > "aarch64|arm64" ?
Not strictly speaking. Any unmatched inputs are passed through as is
https://codereview.appspot.com/86360043/diff/1/juju/arch/arch_test.go File juju/arch/arch_test.go (right):
https://codereview.appspot.com/86360043/diff/1/juju/arch/arch_test.go#newcode40 juju/arch/arch_test.go:40: {"arm64", "arm64"}, On 2014/04/10 10:49:31, thumper wrote: > How does this pass?
If there's no regexp match it just passes through
https://codereview.appspot.com/86360043/
« Back to merge proposal
https:/ /codereview. appspot. com/86360043/ diff/1/ juju/arch/ arch.go
File juju/arch/arch.go (left):
https:/ /codereview. appspot. com/86360043/ diff/1/ juju/arch/ arch.go# oldcode39 arch.go: 39: {regexp. MustCompile( "aarch64" ), ARM64},
juju/arch/
On 2014/04/10 10:49:31, thumper wrote:
> does this line need to be
> "aarch64|arm64" ?
Not strictly speaking. Any unmatched inputs are passed through as is
https:/ /codereview. appspot. com/86360043/ diff/1/ juju/arch/ arch_test. go arch_test. go (right):
File juju/arch/
https:/ /codereview. appspot. com/86360043/ diff/1/ juju/arch/ arch_test. go#newcode40 arch_test. go:40: {"arm64", "arm64"},
juju/arch/
On 2014/04/10 10:49:31, thumper wrote:
> How does this pass?
If there's no regexp match it just passes through
https:/ /codereview. appspot. com/86360043/