juju-core

Code review comment for lp:~wallyworld/juju-core/fix-reported-arch-arm64

  1. fix-reported-arch-arm64
  2. Merge into trunk
Revision history for this message
Tim Penhey (thumper) wrote :

https://codereview.appspot.com/86360043/diff/1/juju/arch/arch.go
File juju/arch/arch.go (left):

https://codereview.appspot.com/86360043/diff/1/juju/arch/arch.go#oldcode39
juju/arch/arch.go:39: {regexp.MustCompile("aarch64"), ARM64},
does this line need to be
"aarch64|arm64" ?

https://codereview.appspot.com/86360043/diff/1/juju/arch/arch_test.go
File juju/arch/arch_test.go (right):

https://codereview.appspot.com/86360043/diff/1/juju/arch/arch_test.go#newcode40
juju/arch/arch_test.go:40: {"arm64", "arm64"},
How does this pass?

https://codereview.appspot.com/86360043/

« Back to merge proposal