Code review comment for lp:~wallyworld/juju-core/fix-instance-type-matching

Revision history for this message
Ian Booth (wallyworld) wrote :

I added a cost based tie breaker

https://codereview.appspot.com/58950043/diff/60001/environs/instances/instancetype.go
File environs/instances/instancetype.go (right):

https://codereview.appspot.com/58950043/diff/60001/environs/instances/instancetype.go#newcode99
environs/instances/instancetype.go:99: // - if no matches and no mem
constraint specified, try again and return any matching instance
On 2014/02/13 15:19:21, fwereade wrote:
> "any": would be nice to tie-break equal-greatest-memory machines by
cost

Done.

https://codereview.appspot.com/58950043/

« Back to merge proposal