Code review comment for lp:~wallyworld/juju-core/fix-instance-type-matching

Reviewers: mp+204159_code.launchpad.net,

Message:
Please take a look.

Description:
Fix instance type selection

Instance type selection will, by default, choose
an instance with enough memory for mong (1024M).
That is unless the user has specified a memory
constraint. If no matching instances are found,
an error is returned. Previously, instead of
an error an arbitary instance with 1024M would
be chosen.

It's perhaps easiest to see the behaviour by
looking at the tests in instancetype_test. With
the old code, several of the tests fail, especially
the memory ones where other constraints are used also.

https://code.launchpad.net/~wallyworld/juju-core/fix-instance-type-matching/+merge/204159

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/58950043/

Affected files (+86, -40 lines):
   A [revision details]
   M environs/instances/instancetype.go
   M environs/instances/instancetype_test.go