Code review comment for lp:~wallyworld/juju-core/agent-conf-upgradedto

Please take a look.

https://codereview.appspot.com/66870044/diff/1/agent/agent_test.go
File agent/agent_test.go (right):

https://codereview.appspot.com/66870044/diff/1/agent/agent_test.go#newcode226
agent/agent_test.go:226: rereadCommands, err := c2.WriteCommands()
On 2014/02/26 02:23:41, thumper wrote:
> these variable names no longer make sense.

Done.

https://codereview.appspot.com/66870044/diff/1/agent/format-1.16.go
File agent/format-1.16.go (right):

https://codereview.appspot.com/66870044/diff/1/agent/format-1.16.go#newcode73
agent/format-1.16.go:73: if value != "" {
On 2014/02/26 02:23:41, thumper wrote:
> I find this much more complicated to follow than a version that
doesn't have
> named params:

> func (*formatter_1_16) upgradedToVersion(value string)
(version.Number, error) {
> if value != "" {
> return version.Parse(value)
> }
> return version.MustParse("1.16.0"), nil
> }

Done.

https://codereview.appspot.com/66870044/