Code review comment for lp:~wallyworld/juju-core/agent-conf-upgradedto

https://codereview.appspot.com/66870044/diff/1/agent/agent.go
File agent/agent.go (right):

https://codereview.appspot.com/66870044/diff/1/agent/agent.go#newcode412
agent/agent.go:412: return c.Write()
If c.Write fails we now have the wrong version stored locally.

Care to fix that?

https://codereview.appspot.com/66870044/diff/1/agent/agent_test.go
File agent/agent_test.go (right):

https://codereview.appspot.com/66870044/diff/1/agent/agent_test.go#newcode226
agent/agent_test.go:226: rereadCommands, err := c2.WriteCommands()
these variable names no longer make sense.

https://codereview.appspot.com/66870044/diff/1/agent/format-1.16.go
File agent/format-1.16.go (right):

https://codereview.appspot.com/66870044/diff/1/agent/format-1.16.go#newcode73
agent/format-1.16.go:73: if value != "" {
I find this much more complicated to follow than a version that doesn't
have named params:

func (*formatter_1_16) upgradedToVersion(value string) (version.Number,
error) {
     if value != "" {
         return version.Parse(value)
     }
     return version.MustParse("1.16.0"), nil
}

https://codereview.appspot.com/66870044/