Code review comment for lp:~wallyworld/juju-core/add-machine-panic

Revision history for this message
Ian Booth (wallyworld) wrote :

https://codereview.appspot.com/12309043/diff/1/cmd/names.go
File cmd/names.go (right):

https://codereview.appspot.com/12309043/diff/1/cmd/names.go#newcode8
cmd/names.go:8: "regexp"
On 2013/08/02 08:51:03, dimitern wrote:
> "regexp"

> "...names"

Done.

https://codereview.appspot.com/12309043/diff/1/cmd/names_test.go
File cmd/names_test.go (right):

https://codereview.appspot.com/12309043/diff/1/cmd/names_test.go#newcode12
cmd/names_test.go:12: type NamesSuite struct {
On 2013/08/02 08:51:03, dimitern wrote:
> s/NamesSuite/namesSuite/ ?

Done.

https://codereview.appspot.com/12309043/diff/1/names/machine.go
File names/machine.go (right):

https://codereview.appspot.com/12309043/diff/1/names/machine.go#newcode14
names/machine.go:14: var (
On 2013/08/02 08:51:03, dimitern wrote:
> var validMachine = ...

Done.

https://codereview.appspot.com/12309043/diff/1/names/service_test.go
File names/service_test.go (right):

https://codereview.appspot.com/12309043/diff/1/names/service_test.go#newcode36
names/service_test.go:36:
On 2013/08/02 08:51:03, dimitern wrote:
> d

Done.

https://codereview.appspot.com/12309043/

« Back to merge proposal