LGTM minus some suggestions below
https://codereview.appspot.com/12309043/diff/1/cmd/names.go File cmd/names.go (right):
https://codereview.appspot.com/12309043/diff/1/cmd/names.go#newcode8 cmd/names.go:8: "regexp" "regexp"
"...names"
https://codereview.appspot.com/12309043/diff/1/cmd/names_test.go File cmd/names_test.go (right):
https://codereview.appspot.com/12309043/diff/1/cmd/names_test.go#newcode12 cmd/names_test.go:12: type NamesSuite struct { s/NamesSuite/namesSuite/ ?
https://codereview.appspot.com/12309043/diff/1/names/machine.go File names/machine.go (right):
https://codereview.appspot.com/12309043/diff/1/names/machine.go#newcode14 names/machine.go:14: var ( var validMachine = ...
https://codereview.appspot.com/12309043/diff/1/names/service_test.go File names/service_test.go (right):
https://codereview.appspot.com/12309043/diff/1/names/service_test.go#newcode36 names/service_test.go:36: d
https://codereview.appspot.com/12309043/
« Back to merge proposal
LGTM minus some suggestions below
https:/ /codereview. appspot. com/12309043/ diff/1/ cmd/names. go
File cmd/names.go (right):
https:/ /codereview. appspot. com/12309043/ diff/1/ cmd/names. go#newcode8
cmd/names.go:8: "regexp"
"regexp"
"...names"
https:/ /codereview. appspot. com/12309043/ diff/1/ cmd/names_ test.go
File cmd/names_test.go (right):
https:/ /codereview. appspot. com/12309043/ diff/1/ cmd/names_ test.go# newcode12 test.go: 12: type NamesSuite struct { namesSuite/ ?
cmd/names_
s/NamesSuite/
https:/ /codereview. appspot. com/12309043/ diff/1/ names/machine. go
File names/machine.go (right):
https:/ /codereview. appspot. com/12309043/ diff/1/ names/machine. go#newcode14 go:14: var (
names/machine.
var validMachine = ...
https:/ /codereview. appspot. com/12309043/ diff/1/ names/service_ test.go test.go (right):
File names/service_
https:/ /codereview. appspot. com/12309043/ diff/1/ names/service_ test.go# newcode36 test.go: 36:
names/service_
d
https:/ /codereview. appspot. com/12309043/