Code review comment for lp:~waldner/terminator/fast-resize

Revision history for this message
Bryce Harrington (bryce) wrote :

> Any news on this?

I would recommend not to use the shift+arrow key combos. I suspect the reason they're unused is because for some people and some keyboards that combo is hit a lot accidentally. If alt+ctrl+shift+arrow is unused by anything, that might be a safer default.

As I think Stephen already mentioned, it's hard to find unused key combos for Terminator, so wise to avoid adding new ones unless absolutely necessary.

If the need for this patch is primarily due to need for configuring your terminal layout on startup, it may be overall better to look at creating a profile with pre-defined terminal window layouts. I can explain how to do this if that's your use case.

In the first comment of the bug report, the idea was floated to make the resize amount for ctrl+shift+arrow configurable. Would that satisfy your requirements? If so, it may be a way to avoid using up key combos.

« Back to merge proposal