Code review comment for lp:~waigani/juju-core/cmd_help_aliases_1299120

Revision history for this message
John A Meinel (jameinel) wrote :

https://codereview.appspot.com/92080046/diff/40001/cmd/juju/main.go
File cmd/juju/main.go (left):

https://codereview.appspot.com/92080046/diff/40001/cmd/juju/main.go#oldcode83
cmd/juju/main.go:83: jujucmd.Register(wrap(&DestroyMachineCommand{}))
On 2014/05/09 06:51:55, fwereade wrote:
> Shouldn't we RemoveMachine as well? if not, why not? :)

It was intended to switch to "juju remove-machine" at least in the bug.

https://codereview.appspot.com/92080046/diff/40001/cmd/juju/removemachine.go
File cmd/juju/removemachine.go (left):

https://codereview.appspot.com/92080046/diff/40001/cmd/juju/removemachine.go#oldcode39
cmd/juju/removemachine.go:39: }
It seems you can't comment on a rename-only change. I wanted to note
that removemachine_test.go certainly seems like it would need updating
for the changes of DestroyMachine to RemoveMachine.

https://codereview.appspot.com/92080046/

« Back to merge proposal