LGTM, but please do the type/var renames for RemoveMachine as well
https://codereview.appspot.com/92080046/diff/40001/cmd/juju/main.go File cmd/juju/main.go (left):
https://codereview.appspot.com/92080046/diff/40001/cmd/juju/main.go#oldcode83 cmd/juju/main.go:83: jujucmd.Register(wrap(&DestroyMachineCommand{})) Shouldn't we RemoveMachine as well? if not, why not? :)
https://codereview.appspot.com/92080046/diff/40001/cmd/juju/removemachine.go File cmd/juju/removemachine.go (left):
https://codereview.appspot.com/92080046/diff/40001/cmd/juju/removemachine.go#oldcode24 cmd/juju/removemachine.go:24: const destroyMachineDoc = ` removeMachineDoc
https://codereview.appspot.com/92080046/diff/40001/cmd/juju/removemachine.go#oldcode31 cmd/juju/removemachine.go:31: func (c *DestroyMachineCommand) Info() *cmd.Info { RemoveMachineCommand
https://codereview.appspot.com/92080046/diff/40001/cmd/juju/removemachine.go File cmd/juju/removemachine.go (right):
https://codereview.appspot.com/92080046/diff/40001/cmd/juju/removemachine.go#newcode34 cmd/juju/removemachine.go:34: # Remove machine 6, running units or containers Remove machine 6, and all its units and containers?
https://codereview.appspot.com/92080046/
« Back to merge proposal
LGTM, but please do the type/var renames for RemoveMachine as well
https:/ /codereview. appspot. com/92080046/ diff/40001/ cmd/juju/ main.go
File cmd/juju/main.go (left):
https:/ /codereview. appspot. com/92080046/ diff/40001/ cmd/juju/ main.go# oldcode83 main.go: 83: jujucmd. Register( wrap(&DestroyMa chineCommand{ }))
cmd/juju/
Shouldn't we RemoveMachine as well? if not, why not? :)
https:/ /codereview. appspot. com/92080046/ diff/40001/ cmd/juju/ removemachine. go removemachine. go (left):
File cmd/juju/
https:/ /codereview. appspot. com/92080046/ diff/40001/ cmd/juju/ removemachine. go#oldcode24 removemachine. go:24: const destroyMachineDoc = `
cmd/juju/
removeMachineDoc
https:/ /codereview. appspot. com/92080046/ diff/40001/ cmd/juju/ removemachine. go#oldcode31 removemachine. go:31: func (c *DestroyMachine Command) Info() mmand
cmd/juju/
*cmd.Info {
RemoveMachineCo
https:/ /codereview. appspot. com/92080046/ diff/40001/ cmd/juju/ removemachine. go removemachine. go (right):
File cmd/juju/
https:/ /codereview. appspot. com/92080046/ diff/40001/ cmd/juju/ removemachine. go#newcode34 removemachine. go:34: # Remove machine 6, running units or
cmd/juju/
containers
Remove machine 6, and all its units and containers?
https:/ /codereview. appspot. com/92080046/