Merge ~vultaire/juju-lint:space-mismatch-ordering into juju-lint:master

[Paul Goins]

Lexicographically sort endpoints in space mismatches

When comparing juju-lint output across clouds, it helps if space mismatches are represented consistently. By sorting the related applications by name, we can provide more consistent output and reduce noise in diffs between juju-lint output from different clouds.

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Alvaro Uria (aluria)]

+1

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision bd5c1aab5603089c7454b5c52771473a64aa1bef

diff --git a/jujulint/check_spaces.py b/jujulint/check_spaces.py
index e9c850b..47c0c63 100644
--- a/jujulint/check_spaces.py
+++ b/jujulint/check_spaces.py
@@ -33,6 +33,10 @@ class SpaceMismatch:
 
     def __init__(self, endpoint1, space1, endpoint2, space2):
         """Create the object."""
+        if endpoint2 < endpoint1:
+            # Let's keep things lexicographically ordered
+            endpoint1, endpoint2 = endpoint2, endpoint1
+            space1, space2 = space2, space1
         self.endpoint1 = endpoint1
         self.endpoint2 = endpoint2
         self.space1 = space1