Merge ~vultaire/charm-hw-health:remove-check-ilorest.py into charm-hw-health:master

[Paul Goins]

[Paul Goins (vultaire)]

This tool actually uses src/files/common/check_hw_health_cron_output.py instead, but when the change to the common file was made, the tool's own version of the script was never removed.

[Drew Freiberger (afreiberger)]

+1, AptVendorTool class defaults to check_hw_health_cron_output.py and ILOrest does not override this.

review: Approve

[Xav Paice (xavpaice)]

Agreed, lgtm

review: Approve

diff --git a/src/files/ilorest/check_ilorest.py b/src/files/ilorest/check_ilorest.py
deleted file mode 100755
index 4d42309..0000000
--- a/src/files/ilorest/check_ilorest.py
+++ /dev/null
@@ -1,71 +0,0 @@
-#!/usr/bin/env python3
-# ------------------------------------------------
-# This file is juju managed
-# ------------------------------------------------
-
-# Copyright (C) 2008, 2009, 2012  James Troup <[e-mail]>
-# Copyright (C) 2009  LaMont Jones <[e-mail]>
-
-###############################################################################
-
-from optparse import OptionParser
-
-from nagios_plugin3 import check_file_freshness, try_check, WarnError, CriticalError
-
-
-###############################################################################
-
-
-def check_and_open(filename, time_limit):
-    check_file_freshness(filename, time_limit)
-    return open(filename)
-
-
-###############################################################################
-
-
-def check_file_contents(input_filename, time_limit):
-    input_file = check_and_open(input_filename, time_limit)
-    for line in input_file.readlines():
-        line = line.rstrip()
-        if not line:
-            continue
-        if line.startswith("WARN"):
-            raise WarnError(line)
-        elif line.startswith("OK"):
-            print(line)
-        else:
-            raise CriticalError(line)
-
-
-###############################################################################
-
-
-def main():
-    parser = OptionParser()
-    parser.add_option(
-        "--time",
-        dest="time_limit",
-        help="freshness time limit [default=%default]",
-        metavar="SECONDS",
-        default=1200,
-        type=int,
-    )
-    parser.add_option(
-        "-f",
-        "--filename",
-        dest="input_file",
-        help=("file containing the output of cron_ilorest.py [default=%default]"),
-        metavar="FILE",
-        default="/var/lib/nagios/ilorest.out",
-        type=str,
-    )
-
-    (opts, args) = parser.parse_args()
-
-    try_check(check_file_contents, opts.input_file, opts.time_limit)
-    print("All OK")
-
-
-if __name__ == "__main__":
-    main()