lp:~vultaire/charm-hw-health

Author: Paul Goins
Author Date: 2020-11-16 23:14:56 UTC

LP#1904032: Fix "lshw -json" parsing on Focal

In Bionic, "lshw -json" output one dictionary per item it was
displaying. In the case of multiple items (e.g. "-class network" with
multiple adapters), it would output multiple dictionaries in sequence.

In Focal, "lshw -json" outputs records in a list, which is more
correct for JSON parsers, however it breaks our current parsing.

The fix is simply to grab the first item in the list and act upon it.
Since the "lshw -json" query outputs the system record by default,
there will only be one item for our case.

Author: Paul Goins
Author Date: 2020-08-12 22:54:58 UTC

Fixed PATH-related issue which broke cron_ilorest.py

Since /usr/sbin/ is not on the PATH via cron, call ilorest as
/usr/sbin/ilorest.

(Thanks Drew for the idea!)

Author: Paul Goins
Author Date: 2020-08-12 21:46:47 UTC

Removing now-unused check file to avoid confusion

Author: Paul Goins
Author Date: 2020-08-11 22:27:12 UTC

Fixed a bug in wait_for_vendor_apt().

There's a clause which tries to do an isinstance check, but does not
instantiate an object from its original class.

This triggered on tools.ILOrest because, while it is a subclass of
tools.AptVendorTool, it is not an instance of it.

>>> isinstance(tools.ILOrest, tools.AptVendorTool)
False

This is fixed by instantiating an ILOrest object and using that instead.

Author: Paul Goins
Author Date: 2020-08-11 20:55:02 UTC

Fix for cron_ilorest.py

Author: Paul Goins
Author Date: 2020-08-11 19:29:13 UTC

Fixed AptVendorTool --filename argument

Author: Paul Goins
Author Date: 2020-08-11 18:56:03 UTC

Fixed error class reference

Author: Paul Goins
Author Date: 2020-08-11 17:42:55 UTC

Fixed inconsistency between get_tools() targets.

get_tools("test") returns a set of classes, while get_tools("auto")
returns a set of instantiated objects.

The charm code expects the classes and instantiates itself, which
results in breakage in the get_tools("auto") case since objects are
returned instead of classes.

This patch updates the reactive module to expect instantiated objects.
get_tools("test") should never be called in production; if it does, it
will break since it returns classes rather than instantiated objetcs.

Author: Paul Goins
Author Date: 2020-08-11 17:42:55 UTC

Fixed inconsistency between get_tools() targets.

get_tools("test") returns a set of classes, while get_tools("auto")
returns a set of instantiated objects.

The charm code expects the classes and instantiates itself, which
results in breakage in the get_tools("auto") case since objects are
returned instead of classes.

This patch simply makes get_tools("auto") also return classes and rely
on the caller doing any needed instantiation.

Author: Paul Goins
Author Date: 2019-10-25 15:28:18 UTC

Forgot to add the symlink for the show-sel action

Author: Paul Goins
Author Date: 2019-10-25 15:28:18 UTC

Forgot to add the symlink for the show-sel action