Merge ~vultaire/charm-hw-health:functest-fix into charm-hw-health:master

[Paul Goins]

[Drew Freiberger (afreiberger)]

I need to see your errors on this. This path works on focal....if asyncio changes between bionic and focal, we need to update the test requirements instead of changing this. I've hit it several many times and gotten useful info from it.

[Paul Goins (vultaire)]

It looks like the exception classes were relocated to asyncio.exceptions in Python 3.8 specifically. That reference unfortunately won't work in anything earlier.

However, it is available via asyncio.TimeoutError, which is what the docs specifically indicate should be used: https://docs.python.org/3.8/library/asyncio-exceptions.html#asyncio.TimeoutError

[Drew Freiberger (afreiberger)]

Thanks for the excellent explanation. I'd pulled the full path from the raised exception, but I see they're imported at the module level, so +1 for this fix. Thanks!

review: Approve

diff --git a/src/tests/functional/test_hwhealth.py b/src/tests/functional/test_hwhealth.py
index d17aae7..e8d60b8 100644
--- a/src/tests/functional/test_hwhealth.py
+++ b/src/tests/functional/test_hwhealth.py
@@ -224,7 +224,7 @@ async def test_checksum_forced_deploy(deploy_app, model, run_command):
             ),
             timeout=DEF_TIMEOUT,
         )
-    except asyncio.exceptions.TimeoutError:
+    except asyncio.TimeoutError:
         print(
             "failed to get expected state 'blocked:Tool megacli - checksum error', "
             "witnessed '{}:{}'".format(