Graylog Charm

Code review comment for ~vultaire/charm-graylog:adding-zaza-tests

  1. Git
  2. lp:~vultaire/charm-graylog
  3. adding-zaza-tests
  4. Merge into master
Revision history for this message
Alvaro Uria (aluria) wrote :

Overall, everything looks good, thank you. I added minor comments (ie. make tests support future HA), and a strong suggestion to use Makefile (and document it in tests/README) to build the charm and run func tests. The Makefile is already there, so the MP probably needs a minor tweak and the tests/README to be updated.

review: Needs Fixing

« Back to merge proposal