Code review comment for lp:~vthompson/ubuntu-weather-app/reboot-sunrise-sunset

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> return Qt.formatDate(getDate(dateData), i18n.tr(format))

We should *never* be exposing the format as a translatable string and should instead be using Qt.locale to display the time/date as per the locale format. Considering that this is something that is also present in trunk, it doesn't block this MP.

« Back to merge proposal