Merge lp:~vthompson/ubuntu-weather-app/reboot-small-homehourly-tweak into lp:ubuntu-weather-app

Proposed by Victor Thompson
Status: Merged
Approved by: Martin Borho
Approved revision: 24
Merged at revision: 24
Proposed branch: lp:~vthompson/ubuntu-weather-app/reboot-small-homehourly-tweak
Merge into: lp:ubuntu-weather-app
Diff against target: 32 lines (+6/-4)
2 files modified
app/components/HomeHourly.qml (+5/-3)
po/com.ubuntu.weather.pot (+1/-1)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/reboot-small-homehourly-tweak
Reviewer Review Type Date Requested Status
Martin Borho Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+253464@code.launchpad.net

This proposal supersedes a proposal from 2015-03-19.

Commit message

* Do not show divider on first HomeHourly delegate.
* Make dividers lighter.

Description of the change

* Do not show divider on first HomeHourly delegate.
* Make dividers lighter.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Martin Borho (martin-borho) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/components/HomeHourly.qml'
--- app/components/HomeHourly.qml 2015-03-03 10:12:15 +0000
+++ app/components/HomeHourly.qml 2015-03-19 04:33:44 +0000
@@ -84,10 +84,12 @@
8484
85 }85 }
86 Rectangle {86 Rectangle {
87 anchors.verticalCenter: parent.verticalCenter
88 color: UbuntuColors.darkGrey
89 height: hourColumn.height
90 opacity: 0.2
91 visible: index > 0
87 width: units.gu(0.1)92 width: units.gu(0.1)
88 height: hourColumn.height
89 color: UbuntuColors.darkGrey
90 anchors.verticalCenter: parent.verticalCenter
91 }93 }
92 }94 }
93 }95 }
9496
=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot 2015-03-16 13:42:08 +0000
+++ po/com.ubuntu.weather.pot 2015-03-19 04:33:44 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: ubuntu-weather-app\n"9"Project-Id-Version: ubuntu-weather-app\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2015-03-06 15:08+0100\n"11"POT-Creation-Date: 2015-03-18 23:24-0500\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"

Subscribers

People subscribed via source and target branches

to all changes: