Code review comment for lp:~vthompson/ubuntu-weather-app/fix-1286589

Revision history for this message
Martin Borho (martin-borho) wrote :

Yeah, thanks! Now it looks good!

So good, I've found a bug in the hourly scrolling. The correct values for wind-mph don't get picked up when scrolling through hours. You can test it when enlarge the window to a big tablet size and by scrolling slowly.

Could you please do me a favour and replace Line 56 in components/ScrollingArea.qml with

currentWeather.windSpeed = currentHour[(mainView.settings.wind_units === 'mph') ? 'imperial' : 'metric'].windSpeed

Would be really cool! Then another bug would be fixed... :)

Cheers
Martin

« Back to merge proposal