I'll approve for now, but if that's ok with you, I'll wait to top-approve until https://code.launchpad.net/~dpm/ubuntu-filemanager-app/fix-desktop-run/+merge/217239 has landed, which also includes some CMakeLists.txt changes and I'd prefer it to land it first: if any conflicts come up from merges, they should be easier to fix on your branch.
Looks good to me, thanks Victor!
I'll approve for now, but if that's ok with you, I'll wait to top-approve until https:/ /code.launchpad .net/~dpm/ ubuntu- filemanager- app/fix- desktop- run/+merge/ 217239 has landed, which also includes some CMakeLists.txt changes and I'd prefer it to land it first: if any conflicts come up from merges, they should be easier to fix on your branch.