Code review comment for lp:~vthompson/ubuntu-filemanager-app/1312879-home-icon

Revision history for this message
David Planella (dpm) wrote :

Looks good to me, thanks Victor!

I'll approve for now, but if that's ok with you, I'll wait to top-approve until https://code.launchpad.net/~dpm/ubuntu-filemanager-app/fix-desktop-run/+merge/217239 has landed, which also includes some CMakeLists.txt changes and I'd prefer it to land it first: if any conflicts come up from merges, they should be easier to fix on your branch.

review: Approve

« Back to merge proposal