Merge lp:~vthompson/sudoku-app/fix-1291603 into lp:sudoku-app

[Victor Thompson]

Fix Qt5.2 lvalue error

Fix Qt5.2 lvalue error

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:168
http://91.189.93.70:8080/job/sudoku-app-ci/74/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1708
    SUCCESS: http://91.189.93.70:8080/job/sudoku-app-raring-amd64-ci/73
    SUCCESS: http://91.189.93.70:8080/job/sudoku-app-saucy-amd64-ci/73
    SUCCESS: http://91.189.93.70:8080/job/sudoku-app-trusty-amd64-ci/26

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/sudoku-app-ci/74/rebuild

review: Approve (continuous-integration)

[Dinko Osmankovic (dinko-metalac)]

Wow, great. Thanks, though I will have to manually teat resizing operation.
Or to figure out autopilot test for that.

BTW, where did you get qt5.2 ? Is that landed in trusty? I still don't have
it.
On 13 Mar 2014 03:35, "Victor Thompson" <email address hidden> wrote:

> Victor Thompson has proposed merging lp:~vthompson/sudoku-app/fix-1291603
> into lp:sudoku-app.
>
> Commit message:
> Fix Qt5.2 lvalue error
>
> Requested reviews:
> Sudoku Touch developers (sudoku-touch-dev)
> Related bugs:
> Bug #1291603 in Sudoku App: "App fails to start under qt5.2"
> https://bugs.launchpad.net/sudoku-app/+bug/1291603
>
> For more details, see:
> https://code.launchpad.net/~vthompson/sudoku-app/fix-1291603/+merge/210730
>
> Fix Qt5.2 lvalue error
> --
> https://code.launchpad.net/~vthompson/sudoku-app/fix-1291603/+merge/210730
> Your team Sudoku Touch developers is requested to review the proposed
> merge of lp:~vthompson/sudoku-app/fix-1291603 into lp:sudoku-app.
>
> === modified file 'sudoku-app.qml'
> --- sudoku-app.qml 2014-02-18 16:22:41 +0000
> +++ sudoku-app.qml 2014-03-13 02:35:21 +0000
> @@ -581,13 +581,11 @@
> if (!gridLoaded && width/height > mainView.resizeFactor)
> return;
> newSize(mainView.width, mainView.height);
> - sudokuBlocksGrid =
> Qt.createComponent(Qt.resolvedUrl("SudokuBlocksGrid.qml"))
> }
> onWidthChanged: {
> if (!gridLoaded && width/height > mainView.resizeFactor)
> return;
> newSize(mainView.width, mainView.height);
> - sudokuBlocksGrid =
> Qt.createComponent(Qt.resolvedUrl("SudokuBlocksGrid.qml"))
> }
>
>
>
>
>

[Victor Thompson (vthompson)]

I upgraded by doing the following:

adb shell
apt-add-repository ppa:ci-train-ppa-service/landing-006
apt-get update
apt-get dist-upgrade
# in case of lxc-android-config or other failures:
# dpkg --configure -a
reboot

I got these instructions from another bug report [1] that I was looking at.

[1] https://bugs.launchpad.net/music-app/+bug/1291398

=== modified file 'sudoku-app.qml'
--- sudoku-app.qml	2014-02-18 16:22:41 +0000
+++ sudoku-app.qml	2014-03-13 02:35:21 +0000
@@ -581,13 +581,11 @@
         if (!gridLoaded && width/height > mainView.resizeFactor)
             return;
         newSize(mainView.width, mainView.height);
-        sudokuBlocksGrid = Qt.createComponent(Qt.resolvedUrl("SudokuBlocksGrid.qml"))
     }
     onWidthChanged: {
         if (!gridLoaded && width/height > mainView.resizeFactor)
             return;
         newSize(mainView.width, mainView.height);
-        sudokuBlocksGrid = Qt.createComponent(Qt.resolvedUrl("SudokuBlocksGrid.qml"))
     }