Code review comment for lp:~vthompson/music-app/use-sheet-pattern

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

I noticed a minor flicker when moving between listing of albums for an artist and the list of tracks for the album selected. The following change stops this flicker.

=== modified file 'common/AlbumsSheet.qml'
--- common/AlbumsSheet.qml 2014-01-05 02:18:39 +0000
+++ common/AlbumsSheet.qml 2014-01-12 22:09:00 +0000
@@ -133,7 +133,6 @@
                                 // TODO: This closes the SDK defined sheet
                                 // component. It should be able to close
                                 // albumSheet.
- PopupUtils.close(sheet)

                                 albumTracksModel.filterAlbumTracks(album)
                                 albumSheet.line1 = artist
@@ -143,6 +142,8 @@
                                 albumSheet.year = year
                                 albumSheet.cover = Library.getAlbumCover(model.album) || Qt.resolvedUrl("../images/cover_default.png")
                                 PopupUtils.open(albumSheet.sheet)
+
+ PopupUtils.close(sheet)

« Back to merge proposal