Ubuntu Music App

Code review comment for lp:~vthompson/music-app/remix-walkthrough

  1. remix-walkthrough
  2. Merge into remix
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Would be good if we could get rid of these console errors

file:///home/andy/Workspace/sdk/vthompson-music-app-remix-walkthrough/common/Walkthrough/Slide2.qml:31:9: QML Column: Cannot specify top, bottom, verticalCenter, fill or centerIn anchors for items inside Column. Column will not function.
file:///home/andy/Workspace/sdk/vthompson-music-app-remix-walkthrough/common/Walkthrough/Slide1.qml:32:9: QML Column: Cannot specify top, bottom, verticalCenter, fill or centerIn anchors for items inside Column. Column will not function.

I'm also worried about the startup cost of always loading the Walkthrough, could you use createObject (the same as MusicNowPlaying) where you push to the stack.

review: Needs Fixing

« Back to merge proposal