Merge lp:~vthompson/music-app/remix-songs-page-elide into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 649
Merged at revision: 651
Proposed branch: lp:~vthompson/music-app/remix-songs-page-elide
Merge into: lp:music-app/remix
Diff against target: 52 lines (+9/-2)
2 files modified
common/MusicRow.qml (+2/-1)
common/SongsPage.qml (+7/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/remix-songs-page-elide
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+237180@code.launchpad.net

Commit message

* Fix elide in Songs Page header
* Fix elide in MusicRow for Songs Page items

Description of the change

This change fixes the elide on the Songs Page, which is a bit off at the moment.

Before:
http://i.imgur.com/5zqTLGn.png
http://i.imgur.com/Getf5Tp.png

After:
http://i.imgur.com/riIDA3A.png
http://i.imgur.com/41EeEjH.png

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/MusicRow.qml'
--- common/MusicRow.qml 2014-10-02 00:49:08 +0000
+++ common/MusicRow.qml 2014-10-05 06:14:12 +0000
@@ -54,7 +54,8 @@
54 top: parent.top54 top: parent.top
55 topMargin: units.gu(1)55 topMargin: units.gu(1)
56 }56 }
57 width: parent.width - coverRow.width - parent.spacing57 width: showCovers ? parent.width - coverRow.width - parent.spacing
58 : parent.width - parent.spacing
5859
59 onSourceComponentChanged: {60 onSourceComponentChanged: {
60 for (var i=0; i < item.children.length; i++) {61 for (var i=0; i < item.children.length; i++) {
6162
=== modified file 'common/SongsPage.qml'
--- common/SongsPage.qml 2014-10-04 01:41:50 +0000
+++ common/SongsPage.qml 2014-10-05 06:14:12 +0000
@@ -90,13 +90,15 @@
90 Label {90 Label {
91 id: albumLabel91 id: albumLabel
92 wrapMode: Text.NoWrap92 wrapMode: Text.NoWrap
93 maximumLineCount: 293 maximumLineCount: 1
94 fontSize: "x-large"94 fontSize: "x-large"
95 color: styleMusic.common.music95 color: styleMusic.common.music
96 anchors {96 anchors {
97 top: albumImage.bottom97 top: albumImage.bottom
98 topMargin: units.gu(1)98 topMargin: units.gu(1)
99 left: albumImage.left99 left: albumImage.left
100 right: parent.right
101 rightMargin: units.gu(2)
100 }102 }
101 elide: Text.ElideRight103 elide: Text.ElideRight
102 text: line2104 text: line2
@@ -115,6 +117,8 @@
115 top: albumLabel.bottom117 top: albumLabel.bottom
116 topMargin: units.gu(0.75)118 topMargin: units.gu(0.75)
117 left: albumImage.left119 left: albumImage.left
120 right: parent.right
121 rightMargin: units.gu(2)
118 }122 }
119 elide: Text.ElideRight123 elide: Text.ElideRight
120 text: line1124 text: line1
@@ -131,6 +135,8 @@
131 : albumLabel.bottom135 : albumLabel.bottom
132 topMargin: units.gu(1)136 topMargin: units.gu(1)
133 left: albumImage.left137 left: albumImage.left
138 right: parent.right
139 rightMargin: units.gu(2)
134 }140 }
135 elide: Text.ElideRight141 elide: Text.ElideRight
136 text: isAlbum && line1 !== i18n.tr("Genre") ? year + " | " + i18n.tr("%1 song", "%1 songs", albumtrackslist.count).arg(albumtrackslist.count)142 text: isAlbum && line1 !== i18n.tr("Genre") ? year + " | " + i18n.tr("%1 song", "%1 songs", albumtrackslist.count).arg(albumtrackslist.count)

Subscribers

People subscribed via source and target branches