Code review comment for lp:~vthompson/music-app/remix-empty-states-001

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Please apply this diff to remove the flicker

=== modified file LibraryListModel.qml
--- LibraryListModel.qml 2014-09-20 10:50:45 +0000
+++ LibraryListModel.qml 2014-10-21 21:36:46 +0000
@@ -33,6 +33,7 @@
     property var param: null
     property bool canLoad: true
     property bool preLoadComplete: false
+ property alias workerComplete: worker.completed

     onCanLoadChanged: {
         /* If canLoad has been set back to true then check if there are any

=== modified file music-app.qml
--- music-app.qml 2014-10-21 18:30:27 +0000
+++ music-app.qml 2014-10-21 21:36:46 +0000
@@ -1156,8 +1156,8 @@
         visible: noMusic || noPlaylists || noRecent

         property bool noMusic: allSongsModel.rowCount === 0 && allSongsModel.status === SongsModel.Ready && loadedUI
- property bool noPlaylists: playlistModel.model.count === 0 && playlistModel.complete
- property bool noRecent: recentModel.model.count === 0 && recentModel.complete
+ property bool noPlaylists: playlistModel.model.count === 0 && playlistModel.workerComplete
+ property bool noRecent: recentModel.model.count === 0 && recentModel.workerComplete
 tools: ToolbarItems {
             back: null
             locked: true

review: Needs Fixing

« Back to merge proposal