Merge lp:~vthompson/music-app/prevent-incorrect-no-music-screen into lp:music-app/trusty
Proposed by
Victor Thompson
Status: | Superseded |
---|---|
Proposed branch: | lp:~vthompson/music-app/prevent-incorrect-no-music-screen |
Merge into: | lp:music-app/trusty |
Diff against target: |
23 lines (+3/-1) 1 file modified
music-app.qml (+3/-1) |
To merge this branch: | bzr merge lp:~vthompson/music-app/prevent-incorrect-no-music-screen |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Andrew Hayzen | Approve | ||
Victor Thompson | Abstain | ||
Review via email: mp+228972@code.launchpad.net |
This proposal has been superseded by a proposal from 2014-08-07.
Commit message
Wait until model is populated before deciding there is no music.
Description of the change
Wait until model is populated before deciding there is no music. There was a new prototype to the Songs model added that provides a "filled" signal that we should listen to in order to determine the model is full.
To post a comment you must log in.
Unmerged revisions
- 544. By Victor Thompson
-
Simplify signal catch.
- 543. By Victor Thompson
-
Fix bad line of code
- 542. By Victor Thompson
-
Wait until model is populated before deciding there is no music.
FAILED: Continuous integration, rev:543 91.189. 93.70:8080/ job/music- app-ci/ 966/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 1219 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 1219/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/music- app-utopic- amd64-ci/ 190
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 966/rebuild
http://