Merge lp:~nskaggs/music-app/prevent-incorrect-no-music-screen into lp:music-app/trusty
Proposed by
Nicholas Skaggs
Status: | Merged |
---|---|
Approved by: | Nicholas Skaggs |
Approved revision: | 559 |
Merged at revision: | 559 |
Proposed branch: | lp:~nskaggs/music-app/prevent-incorrect-no-music-screen |
Merge into: | lp:music-app/trusty |
Diff against target: |
23 lines (+3/-1) 1 file modified
music-app.qml (+3/-1) |
To merge this branch: | bzr merge lp:~nskaggs/music-app/prevent-incorrect-no-music-screen |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Nicholas Skaggs (community) | Approve | ||
Andrew Hayzen | Pending | ||
Victor Thompson | Pending | ||
Review via email: mp+229944@code.launchpad.net |
This proposal supersedes a proposal from 2014-07-31.
Commit message
Wait until model is populated before deciding there is no music. There was a new prototype to the Songs model added that provides a "filled" signal that we should listen to in order to determine the model is full.
Description of the change
Wait until model is populated before deciding there is no music. There was a new prototype to the Songs model added that provides a "filled" signal that we should listen to in order to determine the model is full.
To post a comment you must log in.
FAILED: Continuous integration, rev:543 91.189. 93.70:8080/ job/music- app-ci/ 966/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 1219 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 1219/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/music- app-utopic- amd64-ci/ 190
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 966/rebuild
http://