Merge lp:~vthompson/music-app/make-images-asynchronous into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 680
Merged at revision: 682
Proposed branch: lp:~vthompson/music-app/make-images-asynchronous
Merge into: lp:music-app/remix
Diff against target: 23 lines (+2/-0)
2 files modified
common/BlurredBackground.qml (+1/-0)
common/CoverGrid.qml (+1/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/make-images-asynchronous
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239005@code.launchpad.net

Commit message

Make Images asynchronous

Description of the change

Make Images asynchronous. Discussions with Bill Filler and Renato Filho lead to the idea that images provided by Thumbnailer might be best made asynchronous as to not block the UI. This seems to be the case from initial testing.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/BlurredBackground.qml'
--- common/BlurredBackground.qml 2014-10-20 15:56:44 +0000
+++ common/BlurredBackground.qml 2014-10-21 03:20:36 +0000
@@ -37,6 +37,7 @@
37 id: backgroundImage37 id: backgroundImage
38 anchors.horizontalCenter: parent.horizontalCenter38 anchors.horizontalCenter: parent.horizontalCenter
39 anchors.verticalCenter: parent.verticalCenter39 anchors.verticalCenter: parent.verticalCenter
40 asynchronous: true
40 source: art // this has to be fixed for the default cover art to work - cant find in this dir41 source: art // this has to be fixed for the default cover art to work - cant find in this dir
41 fillMode: Image.PreserveAspectCrop42 fillMode: Image.PreserveAspectCrop
42 height: parent.height43 height: parent.height
4344
=== modified file 'common/CoverGrid.qml'
--- common/CoverGrid.qml 2014-10-20 15:56:44 +0000
+++ common/CoverGrid.qml 2014-10-21 03:20:36 +0000
@@ -53,6 +53,7 @@
53 id: repeat53 id: repeat
54 model: coverGrid.covers.length === 0 ? 1 : coverGrid.covers.length54 model: coverGrid.covers.length === 0 ? 1 : coverGrid.covers.length
55 delegate: Image {55 delegate: Image {
56 asynchronous: true
56 fillMode: Image.PreserveAspectCrop57 fillMode: Image.PreserveAspectCrop
57 height: coverGrid.size / (coverGrid.covers.length > 1 ? 2 : 1)58 height: coverGrid.size / (coverGrid.covers.length > 1 ? 2 : 1)
58 width: coverGrid.size / (coverGrid.covers.length > 2 && !(coverGrid.covers.length === 3 && index === 2) ? 2 : 1)59 width: coverGrid.size / (coverGrid.covers.length > 2 && !(coverGrid.covers.length === 3 && index === 2) ? 2 : 1)

Subscribers

People subscribed via source and target branches