Code review comment for lp:~vthompson/music-app/lookup-file

Revision history for this message
Victor Thompson (vthompson) wrote :

I'll reset selectedAlbum back to false... I don't think we'd catch the filled signal again. BUT if it's called when a new song is added by ms2 we wouldn't want the album to reload.

I think we should still have the track var be set to false by default. The code that handles lookup [1] throws an exception when found which should exit the function... leaving the track variable false as we are assuming.

[1] http://bazaar.launchpad.net/~mediascanner-team/mediascanner2/trunk/view/head:/src/mediascanner/MediaStore.cc#L394

« Back to merge proposal