Merge lp:~vthompson/music-app/fixes-1253480-1253788-ap-tests into lp:music-app/trusty

[Victor Thompson]

Fix shuffle and previous tests for when the play duration was over 5 seconds

The Shuffle and Previous track tests started failing due to a change that was made to skip to the beginning of the song instead of the previous track when the previous button was selected and the track's playing duration was over 5 seconds. These test updates pause the track in these instances so the song does not play past the 5 second mark.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:255
http://91.189.93.70:8080/job/music-app-ci/325/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/198
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/325
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/327
    SUCCESS: http://91.189.93.70:8080/job/music-app-trusty-amd64-ci/46

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/325/rebuild

review: Approve (continuous-integration)

[Nicholas Skaggs (nskaggs)]

Victor, can we test both the hitting the previous button at <5 and at >5 seconds?

[Victor Thompson (vthompson)]

I suppose we should add a test that intentionally hits the previous button
after 5 seconds. Do you think such a test needs to be introduced with this
merge? Or should we just file a bug to request a new test?

On Thu, Nov 21, 2013 at 7:48 PM, Nicholas Skaggs <
<email address hidden>> wrote:

> Victor, can we test both the hitting the previous button at <5 and at >5
> seconds?
> --
>
> https://code.launchpad.net/~vthompson/music-app/fixes-1253480-1253788-ap-tests/+merge/196203
> You are the owner of
> lp:~vthompson/music-app/fixes-1253480-1253788-ap-tests.
>

[Nicholas Skaggs (nskaggs)]

Let's just add it as a bug, and add it in another mp :-)

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/music-app-autolanding/327/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/203
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-autolanding/326
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-autolanding/326
    SUCCESS: http://91.189.93.70:8080/job/music-app-trusty-amd64-autolanding/21

review: Needs Fixing (continuous-integration)

[Victor Thompson (vthompson)]

Toolbar collapsed after pause was hit, causing multiple failures when autopilot clicked outside the window, which caused a context menu to be opened.

[lp:~vthompson/music-app/fixes-1253480-1253788-ap-tests]

256. By Victor Thompson on 2013-11-22

Update test for when toolbar collapses during shuffle test

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:256
http://91.189.93.70:8080/job/music-app-ci/326/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/204
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/326
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/328
    SUCCESS: http://91.189.93.70:8080/job/music-app-trusty-amd64-ci/47

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/326/rebuild

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/music_app/tests/test_music.py'
--- tests/autopilot/music_app/tests/test_music.py	2013-11-16 19:36:00 +0000
+++ tests/autopilot/music_app/tests/test_music.py	2013-11-22 16:59:15 +0000
@@ -116,22 +116,28 @@
         first_genre_item = self.main_view.get_first_genre_item()
         self.pointing_device.click_object(first_genre_item)
 
+        playbutton = self.main_view.get_now_playing_play_button()
+
+        """ Pause track """
+        self.pointing_device.click_object(playbutton)
+        self.assertThat(self.main_view.isPlaying, Eventually(Equals(False)))
+
+        """ Repeat is off """
         repeatbutton = self.main_view.get_repeat_button()
-
-        previousbutton = self.main_view.get_previous_button()
-
-        title = lambda: self.main_view.currentTracktitle
-        artist = lambda: self.main_view.currentArtist
-        self.assertThat(title,
-                        Eventually(Equals("Foss Yeaaaah! (Radio Edit)")))
-        self.assertThat(artist, Eventually(Equals("Benjamin Kerensa")))
-
-        """ Track is playing, repeat is off"""
-        self.assertThat(self.main_view.isPlaying, Equals(True))
         self.pointing_device.click_object(repeatbutton)
+
+        previousbutton = self.main_view.get_previous_button()
+
+        title = lambda: self.main_view.currentTracktitle
+        artist = lambda: self.main_view.currentArtist
+        self.assertThat(title,
+                        Eventually(Equals("Foss Yeaaaah! (Radio Edit)")))
+        self.assertThat(artist, Eventually(Equals("Benjamin Kerensa")))
+
+        """ Select previous """
         self.pointing_device.click_object(previousbutton)
 
-        """ Track is playing"""
+        """ Track is playing """
         self.assertThat(self.main_view.isPlaying, Eventually(Equals(True)))
         self.assertThat(title, Eventually(Equals("TestMP3Title")))
         self.assertThat(artist, Eventually(Equals("TestMP3Artist")))
@@ -149,6 +155,8 @@
 
         previousbutton = self.main_view.get_previous_button()
 
+        playbutton = self.main_view.get_now_playing_play_button()
+
         title = lambda: self.main_view.currentTracktitle
         artist = lambda: self.main_view.currentArtist
         self.assertThat(title,
@@ -180,5 +188,13 @@
                     self.main_view.currentArtist == "TestMP3Artist"):
                 break
             else:
+                """ Show toolbar if hidden """
+                if (not self.main_view.toolbarShown):
+                    self.main_view.show_toolbar()
+
+                """ Pause track """
+                self.pointing_device.click_object(playbutton)
+                self.assertThat(self.main_view.isPlaying,
+                                Eventually(Equals(False)))
                 forward = not forward
                 count += 1