Code review comment for lp:~vthompson/music-app/fix-1515067

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

When testing this branch, the artist/album art was correctly created.

I noticed that the local music scope has fallback cover art for where we have art and empty items for where we have fallback, I wonder if this is known or a bug ?

As stated the other comments, it is unclear if specifying the album for artistart helps with accuracy.

For now, I'm going to approve as this reduces the number of calls, which is what it is trying to fix, and we can add sending the album later if required.

review: Approve

« Back to merge proposal