Merge lp:~vthompson/music-app/fix-1416115 into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 820
Merged at revision: 820
Proposed branch: lp:~vthompson/music-app/fix-1416115
Merge into: lp:music-app/remix
Diff against target: 63 lines (+20/-0)
2 files modified
common/AlbumsPage.qml (+10/-0)
common/SongsPage.qml (+10/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-1416115
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+248071@code.launchpad.net

Commit message

* Make stroked buttons elide text

Description of the change

* Make stroked buttons elide text

To test, either change the displayed text for the top 2 buttons in common/SongsPage.qml and common/AlbumsPage.qml, or change your device's language to German to witness the elide on the middle button.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Allows the buttons in the 'header' of the listview to elide for both AlbumsPage and SongPage :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/AlbumsPage.qml'
--- common/AlbumsPage.qml 2015-01-28 02:32:24 +0000
+++ common/AlbumsPage.qml 2015-01-30 01:25:53 +0000
@@ -60,8 +60,13 @@
60 centerIn: parent60 centerIn: parent
61 }61 }
62 color: "white"62 color: "white"
63 elide: Text.ElideRight
64 height: parent.height
65 horizontalAlignment: Text.AlignHCenter
63 // TRANSLATORS: this appears in a button with limited space (around 14 characters)66 // TRANSLATORS: this appears in a button with limited space (around 14 characters)
64 text: i18n.tr("Shuffle")67 text: i18n.tr("Shuffle")
68 verticalAlignment: Text.AlignVCenter
69 width: parent.width - units.gu(2)
65 }70 }
66 onClicked: shuffleModel(songArtistModel)71 onClicked: shuffleModel(songArtistModel)
67 }72 }
@@ -75,8 +80,13 @@
75 centerIn: parent80 centerIn: parent
76 }81 }
77 color: "white"82 color: "white"
83 elide: Text.ElideRight
84 height: parent.height
85 horizontalAlignment: Text.AlignHCenter
78 // TRANSLATORS: this appears in a button with limited space (around 14 characters)86 // TRANSLATORS: this appears in a button with limited space (around 14 characters)
79 text: i18n.tr("Queue all")87 text: i18n.tr("Queue all")
88 verticalAlignment: Text.AlignVCenter
89 width: parent.width - units.gu(2)
80 }90 }
81 onClicked: addQueueFromModel(songArtistModel)91 onClicked: addQueueFromModel(songArtistModel)
82 }92 }
8393
=== modified file 'common/SongsPage.qml'
--- common/SongsPage.qml 2015-01-28 02:27:52 +0000
+++ common/SongsPage.qml 2015-01-30 01:25:53 +0000
@@ -308,8 +308,13 @@
308 centerIn: parent308 centerIn: parent
309 }309 }
310 color: "white"310 color: "white"
311 elide: Text.ElideRight
312 height: parent.height
313 horizontalAlignment: Text.AlignHCenter
311 // TRANSLATORS: this appears in a button with limited space (around 14 characters)314 // TRANSLATORS: this appears in a button with limited space (around 14 characters)
312 text: i18n.tr("Shuffle")315 text: i18n.tr("Shuffle")
316 verticalAlignment: Text.AlignVCenter
317 width: parent.width - units.gu(2)
313 }318 }
314 onClicked: {319 onClicked: {
315 shuffleModel(albumtrackslist.model) // play track320 shuffleModel(albumtrackslist.model) // play track
@@ -335,8 +340,13 @@
335 centerIn: parent340 centerIn: parent
336 }341 }
337 color: "white"342 color: "white"
343 elide: Text.ElideRight
344 height: parent.height
345 horizontalAlignment: Text.AlignHCenter
338 // TRANSLATORS: this appears in a button with limited space (around 14 characters)346 // TRANSLATORS: this appears in a button with limited space (around 14 characters)
339 text: i18n.tr("Queue all")347 text: i18n.tr("Queue all")
348 verticalAlignment: Text.AlignVCenter
349 width: parent.width - units.gu(2)
340 }350 }
341 onClicked: addQueueFromModel(albumtrackslist.model)351 onClicked: addQueueFromModel(albumtrackslist.model)
342 }352 }

Subscribers

People subscribed via source and target branches